Allow changing background color #404
Conversation
Removing the default values from help text
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 97.38% 97.46% +0.08%
==========================================
Files 38 40 +2
Lines 420 434 +14
==========================================
+ Hits 409 423 +14
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -38,6 +38,10 @@ msgstr "Favicon" | |||
| msgid "Title" | |||
| msgstr "Titre" | |||
|
|
|||
| #: admin_interface/admin.py | |||
| msgid "Body" | |||
| msgstr "Body" | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Changed ! Thanks for feedback !
| @@ -174,10 +178,30 @@ msgstr "code" | |||
| msgid "display" | |||
| msgstr "affichage" | |||
|
|
|||
| #: admin_interface/models.py | |||
| msgid "Required fields, error messages" | |||
| msgstr "Défaut: #333 (champs requis, messages d'erreur)" | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Changed ! Thanks for feedback !
|
Hello there @fabiocaccamo :) |
| #: admin_interface/models.py | ||
| msgid "background color" | ||
| msgstr "couleur d'arrière-plan" | ||
|
|
||
| #: admin_interface/models.py | ||
| msgid "Optional fields, help text, field content" | ||
| msgstr "Défaut: #666 (champs optionnels, texte d'aide, contenu des champs)" |
There was a problem hiding this comment.
Here we still have more info in the translation than the original!
There was a problem hiding this comment.
Maybe this PR could add a single migration
|
@BMourguesFieldbox @merwok sorry for the long silence on this PR. The main reason is that since Django introduced CSS variables, I would rewrite all the color fields of the theme model to match the CSS variables exposed by Django. By approaching the problem in this way, supporting dark-themes would be much easier. |
name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo
Describe your changes
I added 4 customization options to Themes :
And extended French translation for the newly added fields.
I couldn't find places where loud color was used, but it felt awkward to add the option for the quiet color without the loud color.
Related issue
#291
Checklist before requesting a review
I'm reopening this because the change was reverted, but no idea why ? So far, I've used my own fork on different projects without any noticeable issue